Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langs german + spanish 2.10.7, done #48

Merged
merged 50 commits into from
Jun 9, 2024

Conversation

TheblueJo
Copy link
Contributor

There were 5000+ additions, so it'll take a few days or weeks until I've completed german and spanish translations.
Currently (only german):

  • Move phrases during battle
  • Battle ui menu langs
    Not yet:
  • Move names + descriptions
  • TMs
  • spanish

@smell-of-curry
Copy link
Owner

Yeah I Know, hahah it's going to be a lot. now that the entire addon is translatable.

@TheblueJo
Copy link
Contributor Author

There are some berries from J to L that aren't there (?):
Hopo Berry, Jaboca Berry, Kasib Berry, Kebia Berry, Kee Berry, Kelpsy Berry, Lansat Berry.

@smell-of-curry
Copy link
Owner

Oh shoot, well I used the ones pixelmon had. I guess there missing some

@smell-of-curry
Copy link
Owner

Never mind, we are only missing Hopo Berry

@smell-of-curry
Copy link
Owner

Let me know when this is done

@TheblueJo
Copy link
Contributor Author

The last 3 abilities are not official
Some abilities that aren't listed / implemented which I found are: Mind's Eye, Poison Puppeteer, Supersweet Syrup, Tera Shell, Tera Shift, Teraform Zero, Toxic Chain, Hospitality and Embody Aspect

@Idkthisisfordahaxks
Copy link

Im confused with the final 2 steps to get the beh pack

@smell-of-curry
Copy link
Owner

Final 2 steps?

@smell-of-curry
Copy link
Owner

hows it going?

@TheblueJo
Copy link
Contributor Author

The TMs, Ability descriptions, Moves, Move descriptions, battle item descriptions, and some Spanish battle UI texts are left

@smell-of-curry
Copy link
Owner

hows this?

@TheblueJo
Copy link
Contributor Author

Not done yet...
I've been very busy recently and I think that unless you want everything in a single merge it'd be ok to split this in 2. The battle ui texts are done. The item descriptions aren't implemented/used in the addon as far as I know and the abilities' descriptions neither. The moves and their descriptions are going to take time too.

@TheblueJo
Copy link
Contributor Author

Also a little suggestion: can we add or remove the _ underscore from/to item names, so the item in the showdown.item.x and item.x have the same x? Currently they're

  • showdown.items.blackbelt.name=Black Belt, and
  • item.pokeb:black_belt=Black Belt
    having blackbelt as x for as an example

@TheblueJo
Copy link
Contributor Author

This will be finished by sunday, I think

@TheblueJo TheblueJo changed the title Langs german 2.10.0, not done yet Langs german + spanish 2.10.7, done Jun 2, 2024
@TheblueJo
Copy link
Contributor Author

Done

@smell-of-curry smell-of-curry merged commit f346382 into smell-of-curry:main Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants