[GS-8040] Add open upper bound capability to step query
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8c83a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JBezerra
requested review from
stellarhoof,
conraddavisjr,
positiveVibes4all,
PranitaJainB and
sandhya-spend
JBezerra
force-pushed
the
GS-8040/pop-filter-enhancements
branch
from
b7c9085 to
98299f3
Compare
|
Coverage after merging GS-8040/pop-filter-enhancements into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
conraddavisjr
approved these changes
Aug 29, 2024
stellarhoof
requested changes
Aug 29, 2024
There was a problem hiding this comment.
With the removal of steps from the node, this step filter is even closer to the number filter so we should consolidate the implementation.
We can do this by adding a flag calculateRangeTotal to the number node which defaults to false (to preserve current behavior). Ex:
let result = async(node, search) {
return F.compactObject({
// Preserve existing best range functionality
bestRange: node.findBestRange && (await findBestRange()),
// Add ability to calculate the range total
rangeTotal: node.calculateRangeTotal && (await calculateRangeTotal())
})
}Update
Ignore my comment above. There is a product requirement for users to be able to switch between the default number component and the slider component and currently that's only supported with different node types so we cannot consolidate step and number for now.
stellarhoof
approved these changes
Aug 29, 2024
| range: { [field]: pickSafeNumbers({ gte: min }) }, | ||
| } | ||
| } | ||
|
|
||
| return { | ||
| range: { [field]: pickSafeNumbers({ gte: min, lte: max }) }, |
There was a problem hiding this comment.
suggestion: Delete getMinAndMax function.
Suggested change
| range: { [field]: pickSafeNumbers({ gte: min, lte: max }) }, | |
| range: { [field]: pickSafeNumbers({ gte: range[0], lte: range[1] }) }, |
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| let result = async (node, search) => { | ||
| let { field, range, steps } = node | ||
| const result = await search(buildQuery(field, range, steps)) | ||
| let { field, range } = node |
There was a problem hiding this comment.
suggestion: Preserve the number API
The number type uses min/max instead of range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GS-8040
Context
In order to have a controlled way to add/remove an extra step with an open upper bound at the Step Slider component, we need to implement that capability on the
stepquery as well.In order to have better understanding how to link the changes of this PR to your local spark, please read the docs.
TL;DR Version
On Spark
On Contexture
On WebApp
Population Countfilter to your Spending page.Demo
2024-08-28.15-19-08.mp4