SDLCORE-925 Fixed Crash related to HandleOnEvent #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDLCORE-925 Added remove_observer() before calling RemoveRequest() to ensure that command object from observer is removed first and the shared pointer probably_expired doesnt delete the object when HandleOnEvent() is in progress.
|
Supposedly #3951 fixed the same issue. @LuxoftAKutsan can this PR be closed? |
My understanding is yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3410
This PR is not ready for review.
Risk
This PR makes no API changes.
Testing Plan
Regression check
Summary
Added remove_observer() before calling RemoveRequest() to ensure that command object from observer is removed first and the shared pointer probably_expired
doesnt delete the object when HandleOnEvent() is in progress.
Tasks Remaining:
CLA