Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed setup of last_processed_event_ #1616

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LitvinenkoIra
Copy link
Contributor

@LitvinenkoIra LitvinenkoIra commented Jun 15, 2017

  • UPDATE_NEEDED is sent if user requested PTU from HMI
    Main problem that it is the only one case when we should not send notification about update needed on HMI.
  • This notification is sends in callback of starting PT exchange. And to avoid sending this notification we need have information about trigger of UPDATE_NEEDED state, so why do we added new variable to store last status.
  • If SDL stores last status it is possible to check if PTU was triggered by user request, or not.

And in this PR I add missed last_processed_event_ key setup from changes related to "Fix UPDATE_NEEDED is sent if user requested PTU from HMI". #1491

Add missed last_processed_event_ key setup from changes related to "Fix UPDATE_NEEDED is sent if user requested PTU from HMI".
@LitvinenkoIra
Copy link
Contributor Author

@LuxoftAKutsan @dev-gh @AByzhynar @AKalinich-Luxoft please review

@dev-gh
Copy link
Contributor

dev-gh commented Jun 19, 2017

@LitvinenkoIra
Please write PR description that gives answers to:

  • what was the issue? (E.g. 'SDL sends same update status twice')
  • what was done to resolve the issue (E.g. 'Added new variable to store last status')
  • why it was done in that way? (E.g. 'If SDL stores last status it is possible to check whether next event changes status to same or another value')

Currently you just describe obvious things seen from code difference but w/o any understanding what for and why.

@LuxoftAKutsan
Copy link
Contributor

@LitvinenkoIra please specify more clearly what was the defect and root cause.

@LitvinenkoIra
Copy link
Contributor Author

@dev-gh @LuxoftAKutsan updated description

@JenkinsSDLOnCloud
Copy link

Can one of the admins verify this patch?

2 similar comments
@JenkinsSDLOnCloud
Copy link

Can one of the admins verify this patch?

@JenkinsSDLOnCloud
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants