offchain - commit store updates fetching optimization

[dimkouv]

So far the commit plugin keeps fetching multiple logs/events that were already fetched on the previous ocr2 round

func getTokenPriceUpdates() {
          updates = db.getTokenPriceUpdatesOfLast24Hours()
          ...
}

But this is not efficient for the performance of the db and the plugin.

---

A better approach would be to only get the new token price updates since the last time this call was made.

func getTokenPriceUpdates() {
          if there are no updates in mem {
                    updates = db.getTokenPriceUpdatesOfLast24Hours()
          } else {
                    newUpdates = db.getUpdatesThatHappenedAfterTheLastQuery()
                    updates.include(newUpdates)
         }
}

[jarnaud]

Shouldn't we keep the lock over the entire method?

[dimkouv]

If we keep the lock over the entire method we will have a deadlock.

If we use only a Lock() over the entire method, instead of both RLock() for read and Lock() for updates then it's slightly less efficient.

[dimkouv]

Closing, seems that we are not going with this approach atm.
Will re-open if required.