Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated zkSync scripts & instructions #1587

Open
wants to merge 5 commits into
base: ccip-develop
Choose a base branch
from
Open

updated zkSync scripts & instructions #1587

wants to merge 5 commits into from
+46 −6

Conversation

simsonraj
Copy link
Collaborator

Motivation

Solution

@simsonraj simsonraj requested review from makramkd, elatoskinas, RayXpub and a team as code owners January 6, 2025 17:16
flodesi
flodesi reviewed Jan 6, 2025
View reviewed changes
contracts/scripts/zksyncverify/README.md Outdated
@@ -1,5 +1,9 @@
# Verify ZkSync Contracts For CCIP

G++ <-> CCIP repo artifacts mapping
- The current version of zkSync artifacts in G++ was generated with `v2.14.0-ccip1.5.0` version of zkSync contracts.
- For MCMS contracts change the zkSolc version to v1.5.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 1.5.0? ex. https://explorer.zksync.io/address/0xAbB7f1aac7099A9643850A28522EBfC877f5cDC6#contract

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, updated

@simsonraj simsonraj requested a review from matYang January 6, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnieeG AnieeG AnieeG approved these changes

@flodesi flodesi flodesi approved these changes

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

@matYang matYang Awaiting requested review from matYang

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simsonraj @mateusz-sekara @flodesi @AnieeG