-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitlayer OCR configs to CCIP #1543
Open
ma33r
wants to merge
3
commits into
ccip-develop
Choose a base branch
from
SHIP-3962/add-bitlayer-configs
base: ccip-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ChainID = '200901' | ||
| FinalityTagEnabled = false | ||
| FinalityDepth = 21 # confirmed with Bitlayer team and recommended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1 | ||
|
|
||
| [EVM.GasEstimator] | ||
| EIP1559DynamicFees = true | ||
| PriceMax = '1 gwei' # DS&A recommended value | ||
| PriceMin = '40 mwei' # During testing, we saw minimum gas prices ~50 mwei | ||
| PriceDefault = '1 gwei' # As we set PriceMax to '1 gwei' and PriceDefault must be less than or equal to PriceMax | ||
| FeeCapDefault = '1 gwei' # As we set PriceMax to '1 gwei' and FeeCapDefault must be less than or equal to PriceMax | ||
| TipCapDefault = '0.05 gwei' # recommended by BitLayer's docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutGas | ||
|
|
||
| [EVM.GasEstimator.BlockHistory] | ||
| # Default is 8, which leads to bumpy gas prices. In CCIP | ||
| # we want to smooth out the gas prices, so we increase the sample size. | ||
| BlockHistorySize = 200 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ChainID = '200810' | ||
| FinalityTagEnabled = false | ||
| FinalityDepth = 21 # confirmed with Bitlayer team and recommended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1 | ||
|
|
||
| [EVM.GasEstimator] | ||
| EIP1559DynamicFees = true | ||
| PriceMax = '1 gwei' # DS&A recommended value | ||
| PriceMin = '40 mwei' # During testing, we saw minimum gas prices ~50 mwei | ||
| PriceDefault = '1 gwei' # As we set PriceMax to '1 gwei' and PriceDefault must be less than or equal to PriceMax | ||
| FeeCapDefault = '1 gwei' # As we set PriceMax to '1 gwei' and FeeCapDefault must be less than or equal to PriceMax | ||
| TipCapDefault = '0.05 gwei' # recommended by BitLayer's docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutGas | ||
|
|
||
| [EVM.GasEstimator.BlockHistory] | ||
| # Default is 8, which leads to bumpy gas prices. In CCIP | ||
| # we want to smooth out the gas prices, so we increase the sample size. | ||
| BlockHistorySize = 200 | ||
16 changes: 16 additions & 0 deletions
16
core/chains/evm/config/toml/defaults/Bitlayer_Mainnet.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ChainID = '200901' | ||
| FinalityTagEnabled = false | ||
| FinalityDepth = 21 # confirmed with Bitlayer team and recommended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1 | ||
|
|
||
| [EVM.GasEstimator] | ||
| EIP1559DynamicFees = true | ||
| PriceMax = '1 gwei' # DS&A recommended value | ||
| PriceMin = '40 mwei' # During testing, we saw minimum gas prices ~50 mwei | ||
| PriceDefault = '1 gwei' # As we set PriceMax to '1 gwei' and PriceDefault must be less than or equal to PriceMax | ||
| FeeCapDefault = '1 gwei' # As we set PriceMax to '1 gwei' and FeeCapDefault must be less than or equal to PriceMax | ||
| TipCapDefault = '0.05 gwei' # recommended by BitLayer's docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutGas | ||
|
|
||
| [EVM.GasEstimator.BlockHistory] | ||
| # Default is 8, which leads to bumpy gas prices. In CCIP | ||
| # we want to smooth out the gas prices, so we increase the sample size. | ||
| BlockHistorySize = 200 |
16 changes: 16 additions & 0 deletions
16
core/chains/evm/config/toml/defaults/Bitlayer_Testnet.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ChainID = '200810' | ||
| FinalityTagEnabled = false | ||
| FinalityDepth = 21 # confirmed with Bitlayer team and recommended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1 | ||
|
|
||
| [EVM.GasEstimator] | ||
| EIP1559DynamicFees = true | ||
| PriceMax = '1 gwei' # DS&A recommended value | ||
| PriceMin = '40 mwei' # During testing, we saw minimum gas prices ~50 mwei | ||
| PriceDefault = '1 gwei' # As we set PriceMax to '1 gwei' and PriceDefault must be less than or equal to PriceMax | ||
| FeeCapDefault = '1 gwei' # As we set PriceMax to '1 gwei' and FeeCapDefault must be less than or equal to PriceMax | ||
| TipCapDefault = '0.05 gwei' # recommended by BitLayer's docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutGas | ||
|
|
||
| [EVM.GasEstimator.BlockHistory] | ||
| # Default is 8, which leads to bumpy gas prices. In CCIP | ||
| # we want to smooth out the gas prices, so we increase the sample size. | ||
| BlockHistorySize = 200 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to try the Fee History estimator? if its easier to run another quick tests with FHE?
That would avoid the need to set all these Price values in the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had considered the Fee History estimator, but eth_FeeHistory is not supported by Bitlayer. They support a similar RPC method (eth_FeeHistory2), but this would require core code modification to support. (docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/Json-RPC/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can still use the FHE & disable the EIP1559?