Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seq number to CCIPMessageSent event #1481

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Add seq number to CCIPMessageSent event #1481

merged 2 commits into from
Oct 3, 2024

Conversation

RyanRHall
Copy link
Contributor

Motivation

Easily retrieve CCIPMessageSent events in the absence of Atlas / another event indexer

Solution

Add sequenceNumber as an indexed field to CCIPMessageSent event

@RyanRHall RyanRHall requested review from makramkd, elatoskinas, RayXpub and a team as code owners October 2, 2024 18:18
@RyanRHall RyanRHall force-pushed the CCIP-3121-multi-on-ramp-emit-sequence-number-with-ccip-send-requested-event branch from 9f355c1 to 72dea26 Compare October 2, 2024 18:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

LCOV of commit 72dea26 during Solidity Foundry #8493

Summary coverage rate:
  lines......: 97.8% (2263 of 2313 lines)
  functions..: 95.3% (426 of 447 functions)
  branches...: 93.6% (537 of 574 branches)

Files changed coverage rate: n/a

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@RyanRHall RyanRHall merged commit ce11b9f into ccip-develop Oct 3, 2024
127 checks passed
@RyanRHall RyanRHall deleted the CCIP-3121-multi-on-ramp-emit-sequence-number-with-ccip-send-requested-event branch October 3, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elatoskinas elatoskinas elatoskinas approved these changes

@RensR RensR RensR approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanRHall @RensR @elatoskinas