-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] RMNHome #1443
Closed
Closed
[WIP] RMNHome #1443
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
32000bf
fix pragma to 0.8.24
RyanRHall 7cea609
switch to OwnerIsCreator
RyanRHall e915acc
remove XXX comments and test functions
RyanRHall 1061999
reorder imports
RyanRHall be026b6
reorder contract contents
RyanRHall 3dc38c2
create RMNRemote.t.sol and RMNHome.t.sol
RyanRHall 23b02e5
setup RMNHome test
RyanRHall b7627f5
add RMNRemote constructor test
RyanRHall f138f21
add setConfig success test for RMNRemote
RyanRHall d672d82
write setconfig tests
RyanRHall c909164
add initial verify() tests
RyanRHall 1588379
move RMNRemoteSetup contract to it's own file; pre-sort signing addre…
RyanRHall ebfee0c
add out of order / duplicate sig tests
RyanRHall a5c299d
add test_verify_unknownSigner_reverts
RyanRHall 340e24f
write test_verify_insufficientSignatures_reverts
RyanRHall 854ce20
refactor verify() tests
RyanRHall 1f7fba3
incorporate Kostis's RMNRemote changes
RyanRHall 6c592f3
refactor
RyanRHall 9ce03aa
rename curse functions
RyanRHall 156fd67
write tests for cursing / uncursing
RyanRHall 8f44b59
add RMNRemote_global_and_legacy_curses
RyanRHall 0274861
update comments
RyanRHall 14fca9e
move natspec from RMNRemote to IRMNV2
RyanRHall 1e31a6f
add natspec @dev comments to structs
RyanRHall 4ff5f3b
improve natspec
RyanRHall da72d74
update snapshot & wrappers
RyanRHall cb8c0c9
ignore RMNHome from coverage checks
RyanRHall 39f6bfa
Update comment
RyanRHall 750deb2
rename i_chainSelector => i_localChainSelector
RyanRHall 4a9a3f3
remove storage / constructor headers
RyanRHall fb5433d
add comment
RyanRHall 73db111
update comments
RyanRHall 2804858
add new constructor test
RyanRHall e9f90b8
rmn home baseline
RensR 16e15f4
add tests
RensR 5237a5b
add comments, golf
RensR f039e73
increase ring buffer size
RensR af1c04d
Merge f039e73f479ca1fb41ae24dff03148c245df9643 into 2804858b473b732dc…
RensR d6ba29c
Update gethwrappers
app-token-issuer-infra-releng[bot] 2894740
add only owner tests
RensR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a getter for this? That way we don't have to duplicate this constant offchain and nodes can fetch it as part of reading from the remote.