Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO and rename messageValidator to messageInterceptor #1438

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Remove TODO and rename messageValidator to messageInterceptor #1438

merged 4 commits into from
Sep 13, 2024

Conversation

RayXpub
Copy link
Collaborator

@RayXpub RayXpub commented Sep 13, 2024

  • Replaces CCIPConfigTypes.ConfigState /// TODO: explain rollbacks? by rollbacks comment
  • Renames messageValidator to messageInterceptor in ramps

@RayXpub RayXpub requested review from makramkd, elatoskinas and a team as code owners September 13, 2024 09:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

LCOV of commit 14765a3 during Solidity Foundry #8151

Summary coverage rate:
  lines......: 97.6% (2195 of 2248 lines)
  functions..: 94.5% (411 of 435 functions)
  branches...: 93.4% (524 of 561 branches)

Files changed coverage rate: n/a

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@RayXpub RayXpub added this pull request to the merge queue Sep 13, 2024
@RensR RensR removed this pull request from the merge queue due to the queue being cleared Sep 13, 2024
@RensR RensR merged commit bd417ed into ccip-develop Sep 13, 2024
132 checks passed
@RensR RensR deleted the chore/rm-todos-and-var-rename branch September 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@RensR RensR RensR approved these changes

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RayXpub @RensR @makramkd