offchain - place ccip libraries under internal package #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
changed the title
dimkouv
changed the title
dimkouv
commented
Sep 11, 2023
| @@ -75,7 +75,7 @@ MacOSX* | |||
| cache | |||
There was a problem hiding this comment.
@mateusz-sekara > What's the reasoning behind moving all those pkgs into a single internal directory?
cleaning up the repo, step-by-step, followup prs will come, moving under internal/ makes this libs non-importable by other non-ccip packages
There was a problem hiding this comment.
it's going to be something like this
commit_plugin/
exec_plugin/
internal/
libs/
ccip.go
mateusz-sekara
approved these changes
Sep 11, 2023
connorwstein
approved these changes
Sep 12, 2023
|
moved to #133 due to some issue with submodules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.