Multi selction chip group #8
Conversation
There was a problem hiding this comment.
Check file name standards.
| val typedArray = context.theme.obtainStyledAttributes(attrs, R.styleable.SingleLineChipGroup, 0, 0) | ||
| try { | ||
| orientation = typedArray.getInt(R.styleable.SingleLineChipGroup_cg_sl_orientation, Orientation.VERTICAL) | ||
| chipBGColor = typedArray.getColorStateList(R.styleable.SingleLineChipGroup_cg_sl_background) |
There was a problem hiding this comment.
default color should be set here while we fetch color using style.
There was a problem hiding this comment.
applySelector() will execute
| try { | ||
| orientation = typedArray.getInt(R.styleable.SingleLineChipGroup_cg_sl_orientation, Orientation.VERTICAL) | ||
| chipBGColor = typedArray.getColorStateList(R.styleable.SingleLineChipGroup_cg_sl_background) | ||
| chipTextColor = typedArray.getColorStateList(R.styleable.SingleLineChipGroup_cg_sl_textselector) |
There was a problem hiding this comment.
default color should be set here while we fetch color using style. Also, check in other classes for the same.
There was a problem hiding this comment.
applySelector() will execute
| } | ||
| } | ||
|
|
||
| private fun addRadioButtonView(data: RadioGroupData?) { |
There was a problem hiding this comment.
Why we define variable as nullable when we are already passing not nullable data in function?
There was a problem hiding this comment.
File name should be Params
| @@ -0,0 +1,29 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
| <style name="item_title"> | |||
There was a problem hiding this comment.
Give the name "itemTitleStyle". Because you already created the below styles name like that. So that it makes consistent.
# Conflicts: # .idea/.gitignore # app/src/main/java/com/ss/smartfilter/MainActivity.kt # app/src/main/java/com/ss/smartfilter/Utils.kt # ss-smart-filter/src/main/java/com/ss/smartfilterlib/SmartFilter.kt # ss-smart-filter/src/main/java/com/ss/smartfilterlib/singlechoice/radiogroup/MultiLineRadioGroup.kt # ss-smart-filter/src/main/java/com/ss/smartfilterlib/singlechoice/radiogroup/RowItemRadioGroup.kt # ss-smart-filter/src/main/java/com/ss/smartfilterlib/singlechoice/radiogroup/SingleLineRadioGroup.kt # ss-smart-filter/src/main/res/color/single_text_color_selector.xml # ss-smart-filter/src/main/res/drawable/multiline_default.xml # ss-smart-filter/src/main/res/drawable/singleline_rb_selector.xml # ss-smart-filter/src/main/res/values/attrs.xml # ss-smart-filter/src/main/res/values/colors.xml # ss-smart-filter/src/main/res/values/strings.xml # ss-smart-filter/src/main/res/values/themes.xml
Features: