Multi selection listview #10
Conversation
MalaRuparel2023
requested review from
amitsid1408 and
sagarsmartsense
and removed request for
amitsid1408 and
sagarsmartsense
MalaRuparel2023
force-pushed
the
multi_selection_listview
branch
from
0c38a02 to
4c15eec
Compare
| @@ -57,5 +57,10 @@ | |||
| <attr name="cg_sl_orientation" format="integer" /> | |||
| </declare-styleable> | |||
|
|
|||
|
|
|||
| <declare-styleable name="SingleSelectionView"> | |||
| <attr name="ss_textselector" format="reference" /> | |||
There was a problem hiding this comment.
name should be "ss_text_selector"
| <declare-styleable name="SingleSelectionView"> | ||
| <attr name="ss_textselector" format="reference" /> | ||
| <attr name="ss_orientation" format="reference" /> | ||
| <attr name="ss_checkdrawableselector" format="dimension" /> |
There was a problem hiding this comment.
ss_check_drawable_selector
| <attr name="ss_textselector" format="reference" /> | ||
| <attr name="ss_orientation" format="reference" /> | ||
| <attr name="ss_checkdrawableselector" format="dimension" /> | ||
| <attr name="ss_listitem" format="reference" /> |
There was a problem hiding this comment.
Done
Can i make a common style for all custom view ?
There was a problem hiding this comment.
what do you mean by common style?
There was a problem hiding this comment.
total thare are 5 to 6 styleable in attrs file for all custom view and half are almost same . and I have instructed for only bgSelector and tetSelector for version 1
There was a problem hiding this comment.
Let's keep it separate as of now.
There was a problem hiding this comment.
File name: BaseSelection
Class name: BaseClass
It should be consistent. and make sure the class name is proper. You are extending recyclerview. It should be like "BaseRecyclerView". From the name, the user should know about the class itself.
There was a problem hiding this comment.
Make a change of the default value set at initialization.
There was a problem hiding this comment.
separate the class of adapter.
Same as other files if its there.
|
|
||
| inner class SingleSelectionListViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) { | ||
|
|
||
| val cardView: MaterialCardView by lazy { MaterialCardView(itemView.context) } |
There was a problem hiding this comment.
Why we are creating a new object when we already have a view inside the XML file of the adapter class?
And make sure we use viewbinding when needed.
| /** | ||
| * created by Mala Ruparel ON 10/05/24 | ||
| */ | ||
| abstract class BaseLinearLayout<T> : LinearLayout { |
There was a problem hiding this comment.
Is there any usage of generic T?
| /** | ||
| * created by Mala Ruparel ON 08/05/24 | ||
| */ | ||
| abstract class BaseRecycleView<T> : RecyclerView { |
There was a problem hiding this comment.
what is the usage of generic T?
**- Allows selection of multiple items from a list of options.