core: add some missing Encounter.class codes #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These codes were not handled, but now are: - OBSENC (v3) - I (v2 -> IMP) - P (v2 -> PRENC) Additionally, we verify the code system too now.
dogversioning
approved these changes
Jan 7, 2025
Comment on lines
+129
to
+147
| ('AMB', 'AMB', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('EMER', 'EMER', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('FLD', 'FLD', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('HH', 'HH', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('IMP', 'IMP', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('ACUTE', 'ACUTE', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('NONAC', 'NONAC', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('OBSENC', 'OBSENC', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('PRENC', 'PRENC', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('SS', 'SS', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| ('VR', 'VR', 'http://terminology.hl7.org/CodeSystem/v3-ActCode'), | ||
| -- http://terminology.hl7.org/CodeSystem/v2-0004 | ||
| -- This is an older class system, still in active use apparently (at BCH Cerner). | ||
| -- Unmapped codes: B (obstetrics), C (commercial), N (not applicable), U (unknown) | ||
| ('EMER', 'E', 'http://terminology.hl7.org/CodeSystem/v2-0004'), | ||
| ('IMP', 'I', 'http://terminology.hl7.org/CodeSystem/v2-0004'), | ||
| ('AMB', 'O', 'http://terminology.hl7.org/CodeSystem/v2-0004'), | ||
| ('PRENC', 'P', 'http://terminology.hl7.org/CodeSystem/v2-0004'), | ||
| ('AMB', 'R', 'http://terminology.hl7.org/CodeSystem/v2-0004') -- recurring patient |
There was a problem hiding this comment.
have we checked this against a recent-ish epic? just to make sure these codes are actually present in the form we'd expect as opposed to the proprietary format?
There was a problem hiding this comment.
In the export I have from the Epic sandbox, it's always urn:oid:1.2.840.114350.1.72.1.7.7.10.696784.13260 and codes like 13 or 17
There was a problem hiding this comment.
And this field is just a raw coding - so only room for one code & system pair 😦
There was a problem hiding this comment.
Can we use multiple entries in this table? like core/fhir_mapping_tables.sql?
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These codes were not handled, but now are:
Additionally, we verify the code system too now.
Fixes: #333
Checklist
docs/needs to be updatedgenerate-mdcorestudy fields that not in US Core, update our list of those incore-study-details.mdmanifest.toml