Type casting on date filter fix #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dogversioning
commented
Oct 29, 2024
•
dogversioning
commented
- Updates how we try to cast to dates from strings in the chart data endpoint Errors while using filters #136
- Light cleanup on credentials from previous commit
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
dogversioning
commented
Oct 29, 2024
| @@ -29,7 +29,7 @@ def _put_s3_data(name: str, bucket_name: str, client, data: dict, path: str = "a | |||
| def create_auth(client, user: str, auth: str, site: str) -> str: | |||
| """Adds a new entry to the auth dict used to issue pre-signed URLs""" | |||
| site_id = _basic_auth_str(user, auth).split(" ")[1] | |||
| return f'"{site_id}"": {{"site":{site}}}' | |||
| return f'"{site_id}"": {{"user": {user}, "site":{site}}}' | |||
There was a problem hiding this comment.
As soon as this became a hand managed process, having a username in here just for IDing the record became very valuable
mikix
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.