Isolated lambdas, moved auth to secrets manager #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified FilesNo covered modified files...
|
dogversioning
force-pushed
the
mg/secrets_manager
branch
from
7b7f696
to
2d1602c
Compare
dogversioning
commented
Oct 28, 2024
| @@ -1,10 +1,11 @@ | |||
| default_install_hook_types: [pre-commit, pre-push] | |||
| repos: | |||
| - repo: https://github.com/astral-sh/ruff-pre-commit | |||
| rev: v0.2.1 | |||
| rev: v0.5.7 | |||
There was a problem hiding this comment.
Noting for posterity that ruff is now up to v0.7.1 - but here i'm just syncing this to this repo's version
| @@ -26,26 +26,10 @@ def _put_s3_data(name: str, bucket_name: str, client, data: dict, path: str = "a | |||
| client.upload_fileobj(Bucket=bucket_name, Key=f"{path}/{name}", Fileobj=b_data) | |||
|
|
|||
|
|
|||
| def create_auth(client, bucket_name: str, user: str, auth: str, site: str) -> str: | |||
| def create_auth(client, user: str, auth: str, site: str) -> str: | |||
There was a problem hiding this comment.
this is now just a convenience script for getting the password hash
Comment on lines
19
to
42
| def get_secret(): | ||
| """Retrieves a specified secret. | ||
|
|
||
| This is largely unmodified boilerplate from the secrets manager recommended approach | ||
| for fetching secrets, except for getting the values from environment variables""" | ||
|
|
||
| secret_name = os.environ.get("SECRET_NAME") | ||
| region_name = os.environ.get("REGION") | ||
|
|
||
| session = boto3.session.Session() | ||
| client = session.client(service_name="secretsmanager", region_name=region_name) | ||
|
|
||
| try: | ||
| get_secret_value_response = client.get_secret_value(SecretId=secret_name) | ||
| except ClientError as e: | ||
| raise e | ||
|
|
||
| return json.loads(get_secret_value_response["SecretString"]) | ||
|
|
||
|
|
||
| def lambda_handler(event, context): | ||
| del context | ||
| # ---- aggregator specific logic | ||
| user_db = get_s3_json_as_dict( | ||
| os.environ.get("BUCKET_NAME"), f"{BucketPath.ADMIN.value}/auth.json" | ||
| ) | ||
| user_db = get_secret() |
There was a problem hiding this comment.
this is section that is functionality change related to secrets.
mikix
approved these changes
Oct 28, 2024
src/site_upload/api_gateway_authorizer/api_gateway_authorizer.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of files in this PR, but a good 90% of it is just renaming and adding symbolic links.