last valid bugfix/resuable migration tweak #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dogversioning
commented
Oct 25, 2024
dogversioning
commented
- Updates the expected entrypoint for last valid to be hypenated instead of underscore delimited
- Tweak to data package regeneration to match current expected output
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
noting here there's a tension generally between 'use hypens for URLS' and 'use underscores for filesytems' - we could cast back and forth going from s3 path to http, but it's fussier than i'd prefer |
mikix
approved these changes
Oct 25, 2024
scripts/migrations/maintainer.MD
Outdated
There was a problem hiding this comment.
nit: capitalized .MD suffix feels aggressive - this documentation has a degree! 😄
There was a problem hiding this comment.
man i really flipped that caps nomenclature for no reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.