Ruff, dependency upgrades #112
Conversation
dogversioning
force-pushed
the
mg/ruff
branch
2 times, most recently
from
0d8cb16
to
4dce974
Compare
dogversioning
force-pushed
the
mg/ruff
branch
from
4dce974
to
32adbb0
Compare
| @@ -28,7 +27,7 @@ def lambda_handler(event, context): | |||
| if auth_token not in user_db.keys() or auth_header[0] != "Basic": | |||
| raise AuthError | |||
| except (AuthError, KeyError): | |||
| raise AuthError(event) # pylint: disable=raise-missing-from | |||
| raise AuthError(event) # noqa: B904 | |||
There was a problem hiding this comment.
Ugh I hate how less readable that lint-disable is. Is there a reason not to just do what the linter wants here and use from exc?
There was a problem hiding this comment.
because this is in the 'this code came directly from AWS and we're trying to leave that as much as found as possible' bin? you could talk me out of it.
| allowMethods = [] # noqa: RUF012 | ||
| denyMethods = [] # noqa: RUF012 |
There was a problem hiding this comment.
These are valid concerns? Very similar to using a container as a default kwarg - you'll be surprised later and should probably set these in __init__ (or use None as the default).
There was a problem hiding this comment.
this is also in the 'this is AWS code verbatim' bucket. I can go check to see if there's an update over there.
There was a problem hiding this comment.
for posterity: not in the last three years, these vars are re-initialized in the init, i'm inclined to just leave it this way to keep matching the template.
* Ruff * PR feedback, removed unused pylint excepts
* Ruff * PR feedback, removed unused pylint excepts
* Ruff * PR feedback, removed unused pylint excepts
This PR makes the following changes: