PR feedback, removed unused pylint excepts

src/handlers/dashboard/filter_config.py

@@ -73,9 +73,7 @@ def _parse_filter_req(filter_req):
     if "," in filter_req:
         return " AND ".join(_parse_filter_req(x) for x in filter_req.split(","))
     filter_req_split = filter_req.split(":")
-    if (
-        filter_req_split[1] in _FILTER_MAP_ONE_PARAM.keys()  # pylint: disable=consider-iterating-dictionary
-    ):
+    if filter_req_split[1] in _FILTER_MAP_ONE_PARAM:
         return _FILTER_MAP_ONE_PARAM[filter_req_split[1]] % filter_req_split[0]
     return _FILTER_MAP_TWO_PARAM[filter_req_split[1]] % (
         filter_req_split[0],

src/handlers/dashboard/get_chart_data.py

@@ -30,7 +30,7 @@ def _get_table_cols(table_name: str, version: str | None = None) -> list:
     s3_client = boto3.client("s3")
     s3_iter = s3_client.get_object(
         Bucket=s3_bucket_name,
-        Key=s3_key,  # type: ignore[arg-type]
+        Key=s3_key,
     )["Body"].iter_lines()
     return next(s3_iter).decode().split(",")
 
@@ -42,7 +42,7 @@ def _build_query(query_params: dict, filters: list, path_params: dict) -> str:
     filter_str = get_filter_string(filters)
     if filter_str != "":
         filter_str = f"AND {filter_str}"
-    count_col = [next(c for c in columns if c.startswith("cnt"))][0]
+    count_col = next(c for c in columns if c.startswith("cnt"))
     columns.remove(count_col)
     select_str = f"{query_params['column']}, sum({count_col}) as {count_col}"
     group_str = f"{query_params['column']}"

src/handlers/shared/decorators.py

@@ -14,7 +14,7 @@ def error_decorator(func):
         def wrapper(*args, **kwargs):
             try:
                 res = func(*args, **kwargs)
-            except Exception as e:  # pylint: disable=broad-except
+            except Exception as e:
                 trace = []
                 tb = e.__traceback__
                 while tb is not None:

src/handlers/site_upload/api_gateway_authorizer.py

@@ -65,7 +65,7 @@ class HttpVerb:
     ALL = "*"
 
 
-class AuthPolicy:  # pylint: disable=missing-class-docstring; # pragma: no cover
+class AuthPolicy:
     awsAccountId = ""
     """The AWS account id the policy will be generated for. This is used to
     create the method ARNs."""

src/handlers/site_upload/powerset_merge.py

@@ -299,7 +299,7 @@ def merge_powersets(manager: S3Manager) -> None:
             manager.update_local_metadata(
                 TransactionKeys.LAST_AGGREGATION.value, site=latest_site
             )
-        except Exception as e:  # pylint: disable=broad-except
+        except Exception as e:
             manager.merge_error_handler(
                 latest_path,
                 subbucket_path,