-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OTel instrumentation to 2.5.0 #2677
Conversation
@ozangunalp leaving this draft here because I was having problems with the pulsar image locally and also I get a test error that looks unrelated: |
1f09b77
to
50e205a
Compare
@ozangunalp I have no idea if these build errors are relevant for the PR. |
50e205a
to
7bad192
Compare
That was just the documentation module which provides a sample connector with tracing integration. I've pushed a fix. |
@ozangunalp do you think this is good to go? |
Is it ok if we release 4.22.0 without this one and include it in 4.23 ? |
It depends when you want to have this merged on Quarkus... I'm not sure either. |
Ideally, we can cut 4.23 just after with only the OTel update. |
When do you think that can happen? |
Ideally, I think we would need this upgrade merged in Quarkus by next Tuesday. Which means we need the release to happen very very soon (release time + CI time). |
7bad192
to
7375421
Compare
Rebased this on top the 4.22.0 release. If I am not mistaken this means RM will be incompatible with OTel 1.x. |
Yes, this is a Breaking Change for the OTel side. IT should be on the release notes. |
Breaking changes.
For details see: quarkusio/quarkus#41521