Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upozorni danovnika na preddavky init #794

Conversation

Ormi
Copy link
Collaborator

@Ormi Ormi commented Oct 7, 2023

Toto bude asi skarede PR, nie som velmi FE/FullStack clovek a fakt neviem do akeho miesta to poriadne vlozit. Preto som to dal priamo do view/pages cez viac typov returnov view. Inspiroval som sa tym, co som videl v ostatnych ako napriklad deti.tsx.

Upozornenie na preddavky sa zobrazi len ak danovnik este preddavky neplatil, podla infomracii ktore nam poskytol.

Rovnako som pridal aj vypocet kolko priblizne bude platit, podla vypoctu aky bol na FS.

Ak to nie je optimalne tak ma prosim usmernite ako lepsie nato a opravim to.

Rovnako prosim mrknite na wording.

Vsetky mozne stavy ktore mozu nastat (3):

Screenshot from 2023-10-07 16-32-25
Screenshot from 2023-10-07 16-32-42
Screenshot from 2023-10-07 16-33-02

@Ormi Ormi linked an issue Oct 7, 2023 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Oct 7, 2023

Passing run #934 ↗︎

0 64 1 0 Flakiness 0

Details:

Merge 38fe0d0 into 9082a99...
Project: priznanie-digital Commit: 347c81a1b8 ℹ️
Status: Passed Duration: 02:07 💡
Started: Dec 14, 2023 11:51 AM Ended: Dec 14, 2023 11:53 AM

Review all test suite changes for PR #794 ↗︎

@Ormi
Copy link
Collaborator Author

Ormi commented Oct 7, 2023

Mam cas, idem este spravit aj vypocet kolko to cca bude podla vzoru kalkulacky na FS.

@Ormi Ormi self-assigned this Oct 7, 2023
@MarekVigas
Copy link
Collaborator

Vizuál sa mi nejak nezdá. Tá icon mi príde že nie je na stred. Zároveň mi príde že ten text je celkom dlhý a možno by som ho nejak zvýraznil. Možno tú info o sume by som v tom texte napísal skôr a až potom že a viac info môžete nájsť na stránkach finančnej správy.

@Ormi
Copy link
Collaborator Author

Ormi commented Oct 9, 2023

Text som skratil a zvyraznil ako bolo pozadovane. To zaroven samo fixlo problem so zarovnanim.

Screenshot from 2023-10-09 17-34-53

Copy link
Collaborator

@MarekVigas MarekVigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uz to vyzera dobre, este prosim na to doplnme aspon 2 cypress testy. Jeden kde budu mesacne preddavky a druhy kde budu kvartalne

src/pages/vysledky.tsx Outdated Show resolved Hide resolved
src/pages/vysledky.tsx Outdated Show resolved Hide resolved
@Ormi Ormi marked this pull request as draft October 23, 2023 17:34
@MarekVigas MarekVigas marked this pull request as ready for review December 14, 2023 11:50
@MarekVigas MarekVigas merged commit 06a8a62 into master Dec 14, 2023
8 checks passed
@MarekVigas MarekVigas deleted the 786-upozornenie-ze-danovnik-sa-moze-stat-platcom-preddavkov-na-dan branch December 14, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upozornenie ze danovnik sa moze stat platcom preddavkov na dan
2 participants