-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP finishing Feature/ra #9
Open
eronisko
wants to merge
55
commits into
slovensko-digital:feature/ra
Choose a base branch
from
eronisko:feature/ra
base: feature/ra
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,555
−491
Open
Changes from 52 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
d86ad05
Bimp gems
jsuchal e8a2bcc
Add datahub connection config
jsuchal b2d2b03
Initial working example job
jsuchal e61a940
Add test coverage & better test reporting
jsuchal 177ea38
Add badges
jsuchal 4d89101
Merge pull request #2 from slovensko-digital/data-upvs-edesks
jsuchal 8b9a173
Bump gems
jsuchal 115cc05
Add instructions
jsuchal cd6c99e
Add docs badge
jsuchal a580a00
Add code coverage reports
jsuchal df103f9
Add code coverage badge
jsuchal 5c8c8d1
Add staging config
jsuchal 3502c9c
Normalize quotes
jsuchal 7022f05
Add newrelic
jsuchal 89a34e8
Add newrelic gem
jsuchal a0fa76f
Add upvs to open data
jsuchal 15fbcf7
Migrate after deploy
jsuchal d382c3b
Add license
jsuchal 1a10eb4
Update license formatting
jsuchal 11ec000
Update formatting
jsuchal 8e46428
update gems + Ruby to 2.4.1
istana ad04caf
Merge pull request #7 from istana/4/update-gems
jsuchal 133218e
Bump ruby version for dokku
jsuchal 17e11ed
Remove .ruby-version, use Gemfile
jsuchal c866336
Specify version of ox gem
eronisko 49bb8b5
Fix when ChangesBatch is recorded
eronisko b16ebb5
Fix parsing of municipality changes
eronisko 87bff91
Adding consolidated model stubs
eronisko 4502b67
Add relationships from changes to consolidated model stubs via objectId
eronisko 064d3e7
Added most of other relationships between change models and consolida…
eronisko 850ec8e
Fix associations of street name changes with municipalities & districts
eronisko a715e0b
to_i -> Integer()
eronisko e920f6a
Separate out change_id to reference Ra::Change. Use own primary keys
eronisko 7d8b135
DRY-up Ra:RecordBuilder
eronisko 59c5f93
Unified codelist models and tables
eronisko 716ee58
Remove commented-out puts calls
eronisko 6125c1f
Added timeout to Ra::FetchChangesBatchJob downloader
eronisko a064cae
Ensure Ra timedate data is in Bratislava timezone
eronisko 4250eee
Test for BuildingNumberChange.street_name_id
eronisko da5ff8e
Remove pending tests for dumb models
eronisko 9f0e515
Only schedule missing batches for download
eronisko df76532
Ensure Ra::ChangesBatch is not created when there's an error
eronisko 6cf1bed
Wrap Ra::FetchChangesBatchJob#perform in a single transaction
eronisko 2d4af04
Shallow testing for change_id and city_id in Ra::MunicipalityChange
eronisko c9ab4d2
Merge remote-tracking branch 'upstream/master' into feature/ra
eronisko 263dbd7
Merge structure.sql with master
eronisko c6e2973
Remove unique indices from code in _codes tables
eronisko 217315b
Ra::SyncChangesBatchesJob should fail on failed HTTP calls
eronisko bc39f0a
Add indices to Ra::StreetNameChange{Municipality,District} join tables
eronisko 7b29764
Consider Codelist items optional
eronisko af4e9c2
Set backoff timing to default for Ra jobs
eronisko 9f62108
Add effective_on column to ra.municipality_changes
eronisko e17f1ad
Do not set time zone on app level
eronisko 7774ffd
Replacing Harvester::Utils with HarvesterUtils::Downloader
eronisko 0f502d3
Job and Rake task for importing initial batch for address register
eronisko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,5 +15,8 @@ | |
!/log/.keep | ||
!/tmp/.keep | ||
|
||
# Ignore coverage data | ||
/coverage | ||
|
||
# Ignore Byebug command history file. | ||
.byebug_history |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nejaky speci dovod preco fixujeme verziu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ta povodna (2.4.3) mi nesla skompilovat a najnovsia (2.4.13) ma nejake zvlastnosti s whitespaceom. Ak je to problem, mozem sa na to neskor pozriet a nechat to bez verzie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rozumiem, beriem.