Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feature/ra #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP Feature/ra #1

wants to merge 7 commits into from

Conversation

jsuchal
Copy link
Member

@jsuchal jsuchal commented Oct 13, 2016

  • dorobit modely pre Ra::Region, Ra::District... kde bude len id. Bude sluzit len kvoli FK
  • zistit ci nemame koliziu s change_id - v inicialnom importe nie je. Asi bude treba dat vlastny primarny kluc
  • ciselniky vsetky konzistentne - code sting, name string a suffixy _codes na tabulky - napriklad building_purpose este chyba.
  • rozhodit do suborov kde toho je vela (job)
  • pouzivame fetch alebo import nazov pre taketo joby?
  • odstranit todos a puts
  • to_i -> Integer(...)

@jsuchal
Copy link
Member Author

jsuchal commented Apr 26, 2017

Tuto je napisane https://data.gov.sk/dataset/f2b3af7a-b4d4-45d7-9605-29fa5d7ad115/resource/29936968-f4c5-4afc-8c71-a2da2ae142bf/download/package6doc1.htm ze districtIdentifiers a municipalityIdentifiers moze byt zoznam. Cize toto treba fixnut.

image

Cize vyzera, ze ulica moze prechadzat cez viac obci/mestskych casti.

toto je uplna schema https://data.gov.sk/dataset/de3dd18f-9124-4acb-ae00-705555332256/resource/44687156-5f58-4fc4-981c-15e76a51cbdf/download/xmlschema772775956.xsd

)
end

pending 'it adds batch record last'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuchal mas na toto nejaku fintu? Napadlo mi odsledovat poradie volani create k jednotlivym modelom, ale to mi pripada dost krehke.

Asi by som ten test postavil ako creates batch record only after successful import a otestovat, ze ChangesBatch sa nevytvori ak je tam nejaka exception.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eronisko - toto imho len cele zabalit do transakcie. bude to long running tx ale nic sa neda velmi robit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants