GO-128 Do not download related messages to drafts #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Nov 14, 2024
app/jobs/fs/sync_box_job.rb
Outdated
| @@ -4,7 +4,7 @@ def perform(box, from: Date.today - 1.week, to: Date.tomorrow) | |||
| raise unless box.is_a?(Fs::Box) | |||
| return unless box.syncable? | |||
|
|
|||
| box.messages.outbox.find_each do |outbox_message| | |||
| box.messages.outbox.where(type: [nil, 'Message']).find_each do |outbox_message| | |||
There was a problem hiding this comment.
Spravme si tu nejaky scope except_drafts lebo toto sa neda uplne pochopit.
There was a problem hiding this comment.
Alebo mozno not.drafts by sa mohlo tiez dat spravit
There was a problem hiding this comment.
pozeram ze best practice je spravit prefix not_ a nie except_ sorry, necham na tvoje zvazenie.
jsuchal
approved these changes
Nov 14, 2024
luciajanikova
deleted the
GO-128/do_not_download_related_messages_to_drafts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pri syncovani boxu chceme stahovat iba suvisiace spravy k plnohodnotnym outboxovym spravam, aby sme vylucili drafty.