Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-preview: More filter options in Selection Popup #7070

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

hunger
Copy link
Member

@hunger hunger commented Dec 11, 2024

  • Hide layouts,
  • Hide interactive elements

@hunger hunger requested a review from szecket December 11, 2024 18:34
Copy link
Member

@szecket szecket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the functionality will be very useful. I have a sep PR with styling

@szecket
Copy link
Member

szecket commented Dec 11, 2024

I don't know how to add my changes to this now since I did them sep

@hunger
Copy link
Member Author

hunger commented Dec 12, 2024

Where did you push it to? I can move your changes on top of mine. Or we just merge this one and then you do your magic on top. But that will leave my ugly intermediate state visible :-)

Edit: Found your changes in #7071

@hunger hunger force-pushed the tobias/push-wrqmylquwoml branch 2 times, most recently from 88b5bfc to 9e5d4a1 Compare December 12, 2024 09:20
* Hide layouts,
* Hide interactive elements
* Hide others

@szecket did a lot of UI polish that I just merged here
so that I do not need to show what I made!
@hunger hunger force-pushed the tobias/push-wrqmylquwoml branch from 9e5d4a1 to 8c9960c Compare December 12, 2024 20:32
Copy link
Member

@szecket szecket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add focus in another merge. this one works for what it is intended

@szecket szecket merged commit da7ba2f into slint-ui:master Dec 12, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants