Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LayoutSpec and undeprecate StyleMetrics.layout-* properties #7069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ogoffart
Copy link
Member

StyleMetrics is the right name for these

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Simon Hausmann <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@tronical
Copy link
Member

I discussed this also with @nigel and he agreed with me on the StyleMetrics preference. Two additional points he brought to the table:

  • "Metrics" as a standalone term is perhaps too abstract.
  • "StyleMetrics" goes well "FontMetrics" (or font-metrics as property name right now), in terms of overall terminology.

I suggest we continue with StyleMetrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants