Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Better hover information for images in text only editors #7038

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

hunger
Copy link
Member

@hunger hunger commented Dec 9, 2024

Whow the path when the editor can not render the image itself.

Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(If no tests are failling, this means there was not enough tests)

Whow the path when the editor can not render the image itself.
@hunger hunger force-pushed the push-wqsvymzymxpv branch from eec8c39 to b88ec0d Compare December 9, 2024 15:44
@hunger
Copy link
Member Author

hunger commented Dec 9, 2024

But the test was failing, I just missed it due to the other test having stopped to fail :-)

@hunger hunger merged commit 70ad9f2 into slint-ui:master Dec 9, 2024
37 checks passed
@hunger hunger deleted the push-wqsvymzymxpv branch December 9, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants