-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next gen docs for 1.9 #6766
Merged
Next gen docs for 1.9 #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wonder if it would be possible to rebase that to have a cleaner history. @hunger: could you help with that? |
I’ll be back Wednesday, will help try out and review then (here or master if merged by then). |
NigelBreslaw
force-pushed
the
docs-tng
branch
from
November 11, 2024 12:17
10014de
to
45f6a2d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
NigelBreslaw
force-pushed
the
docs-tng
branch
from
November 11, 2024 16:31
d27a794
to
265961f
Compare
tronical
reviewed
Nov 13, 2024
tronical
reviewed
Nov 13, 2024
tronical
reviewed
Nov 13, 2024
tronical
reviewed
Nov 13, 2024
|
||
let project_root = find_project_root(&args.docs_folder)?; | ||
|
||
eprintln!("project_root is {project_root:?}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray debug output?
Fix link
* Add more types * Return the type default value and use that if no default value is set in the properties component * Add a direction into the properties component. Default it to `in`, as that is what is used almost exclusively. * Remove some useless information from the Image and Text Elements: We include the same info from the enum data now!
Lint fixes
Port more elements Make docs more consistent Port more elements
We don't really want to embed freetype on any platform...
The comma as separator is not permitted, but a space is fine. This also fixes an actual syntax error found by the test :)
I suppose some reformatting changed indentation and thus the expected whitespace needs adjusting.
This is used to generate the index at https://snapshots.slint.dev/master/docs/ and pushed to from the website repo.
This should not be needed for the master branch.
(Forgot to save the file earlier)
tronical
approved these changes
Nov 14, 2024
szecket
pushed a commit
to szecket/slint
that referenced
this pull request
Nov 16, 2024
Co-authored-by: Aurindam Jana <[email protected]> Co-authored-by: Tobias Hunger <[email protected]> Co-authored-by: Simon Hausmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR to update the docs for 1.9 using Astro Starlight