Skip to content

Commit

Permalink
Fix hang on startup on some Linux systems
Browse files Browse the repository at this point in the history
When the fontconfig dev package is not installed, servo-fontconfig will fall back to building
its own copy, which may be incompatible with what's on the system. The
result is a horrible start-up time and this patch opts to instead require fontconfig
to be available at build time and error out otherwise.

Fixes issue #88
  • Loading branch information
tronical committed Oct 13, 2020
1 parent 4d4aa81 commit a202b99
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions sixtyfps_runtime/corelib/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,10 @@ wasm-bindgen = { version = "0.2" }
font-kit = "0.10"
pathfinder_geometry = "0.5.1"

# Require font-config from the system. Issue #88 indicates that the copy provided by servo-fontconfig may be incompatible
# with distros at times.
[target.'cfg(not(any(target_family = "windows", target_os = "macos", target_os = "ios", target_arch = "wasm32")))'.dependencies]
servo-fontconfig-sys = { version = "5.1", features = [ "force_system_lib" ] }

This comment has been minimized.

Copy link
@ogoffart

ogoffart Oct 13, 2020

Member

I just had a look, and servo-fontconfig also has that feature, so probably best to use that instead


[dev-dependencies]
pin-weak = "1"

0 comments on commit a202b99

Please sign in to comment.