Skip to content

Commit

Permalink
Update Skia Bindings
Browse files Browse the repository at this point in the history
This allows reverting 18db321 and

Fixes #6615
  • Loading branch information
tronical committed Dec 2, 2024
1 parent aa98768 commit 37c4c30
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 24 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/cpp_package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ jobs:
- name: Prepare licenses
run: bash -x ../../scripts/prepare_binary_package.sh ../..
working-directory: api/cpp/
# Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed.
- uses: actions/setup-python@v5
with:
python-version: '3.12'
- uses: ilammy/msvc-dev-cmd@v1
- name: Select MSVC (windows)
run: |
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/nightly_snapshot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,6 @@ jobs:
target: x86_64-apple-darwin
- name: Install cargo-bundle
run: cargo install --version=0.6.0 cargo-bundle
# Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed.
- uses: actions/setup-python@v5
with:
python-version: '3.12'
- name: Build Main LSP Bundle
working-directory: tools/lsp
run: cargo bundle --release --features ${{ env.SLINT_BINARY_FEATURES }}
Expand All @@ -151,10 +147,6 @@ jobs:
- uses: ./.github/actions/setup-rust
with:
target: aarch64-apple-darwin
# Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed.
- uses: actions/setup-python@v5
with:
python-version: '3.12'
- name: Build AArch64 LSP
run: cargo build --target aarch64-apple-darwin --features ${{ env.SLINT_BINARY_FEATURES }} --release -p slint-lsp
- name: Create artifact directory
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/publish_npm_package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ jobs:
- name: Upgrade LLVM for Skia build on Windows
if: runner.os == 'Windows'
run: choco upgrade llvm
# Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed.
- uses: actions/setup-python@v5
with:
python-version: '3.12'
# Setup .npmrc file to publish to npm
- uses: actions/setup-node@v4
with:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/slint_tool_binary.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,6 @@ jobs:
- uses: ./.github/actions/setup-rust
with:
target: aarch64-apple-darwin
# Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed.
- uses: actions/setup-python@v5
with:
python-version: '3.12'
- uses: baptiste0928/cargo-install@v3
with:
crate: cargo-about
Expand Down
8 changes: 4 additions & 4 deletions internal/renderers/skia/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ pin-weak = "1"
scoped-tls-hkt = "0.1"
raw-window-handle = { version = "0.6", features = ["std"] }

skia-safe = { version = "0.78.0", features = ["textlayout", "gl"] }
skia-safe = { version = "0.80.0", features = ["textlayout", "gl"] }
glow = { version = "0.13" }
unicode-segmentation = { version = "1.8.0" }

Expand All @@ -58,19 +58,19 @@ bytemuck = { workspace = true }

[target.'cfg(target_family = "windows")'.dependencies]
windows = { version = "0.58.0", features = ["Win32", "Win32_System_Com", "Win32_Graphics", "Win32_Graphics_Dxgi", "Win32_Graphics_Direct3D12", "Win32_Graphics_Direct3D", "Win32_Foundation", "Win32_Graphics_Dxgi_Common", "Win32_System_Threading", "Win32_Security"] }
skia-safe = { version = "0.78.0", features = ["d3d"] }
skia-safe = { version = "0.80.0", features = ["d3d"] }

[target.'cfg(target_vendor = "apple")'.dependencies]
objc2 = { version = "0.5.2" }
objc2-metal = { version = "0.2.2", features = ["MTLCommandQueue", "MTLCommandBuffer"] }
objc2-foundation = { version = "0.2.2"}
objc2-quartz-core = { version = "0.2.2" }
objc2-app-kit = { version = "0.2.2" }
skia-safe = { version = "0.78.0", features = ["metal"] }
skia-safe = { version = "0.80.0", features = ["metal"] }
raw-window-metal = "1.0"

[target.'cfg(not(any(target_vendor = "apple", target_family = "windows")))'.dependencies]
skia-safe = { version = "0.78.0", features = ["gl"] }
skia-safe = { version = "0.80.0", features = ["gl"] }

[build-dependencies]
cfg_aliases = { workspace = true }

0 comments on commit 37c4c30

Please sign in to comment.