Arrays/DisallowImplicitArrayCreation: bug fix - recognize global stat…

…ements While it may be unclear whether the variable imported via the `global` statement is an array, the variable does exist, so this is not implicit array creation. Includes tests.
slevomat · Sep 29, 2023 · 5504980 · 5504980
1 parent fc778da
commit 5504980
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 1 deletion.
diff --git a/SlevomatCodingStandard/Sniffs/Arrays/DisallowImplicitArrayCreationSniff.php b/SlevomatCodingStandard/Sniffs/Arrays/DisallowImplicitArrayCreationSniff.php
@@ -12,9 +12,11 @@
 use function in_array;
 use const T_CLOSE_PARENTHESIS;
 use const T_CLOSURE;
+use const T_COMMA;
 use const T_DOUBLE_COLON;
 use const T_EQUAL;
 use const T_FOREACH;
+use const T_GLOBAL;
 use const T_LIST;
 use const T_OBJECT_OPERATOR;
 use const T_OPEN_PARENTHESIS;
@@ -203,6 +205,10 @@ private function hasExplicitCreation(File $phpcsFile, int $scopeOpenerPointer, i
 			if ($this->isCreatedByReferencedParameterInFunctionCall($phpcsFile, $i, $scopeOpenerPointer)) {
 				return true;
 			}
+
+			if ($this->isImportedUsingGlobalStatement($phpcsFile, $i)) {
+				return true;
+			}
 		}
 
 		return false;
@@ -262,4 +268,13 @@ private function isCreatedByReferencedParameterInFunctionCall(File $phpcsFile, i
 		return $tokens[$pointerBeforeParenthesisOpener]['code'] === T_STRING;
 	}
 
+	private function isImportedUsingGlobalStatement(File $phpcsFile, int $variablePointer): bool
+	{
+		$tokens = $phpcsFile->getTokens();
+
+		$startOfStatement = $phpcsFile->findStartOfStatement($variablePointer, T_COMMA);
+
+		return $tokens[$startOfStatement]['code'] === T_GLOBAL;
+	}
+
 }
diff --git a/tests/Sniffs/Arrays/DisallowImplicitArrayCreationSniffTest.php b/tests/Sniffs/Arrays/DisallowImplicitArrayCreationSniffTest.php
@@ -17,7 +17,7 @@ public function testErrors(): void
 	{
 		$report = self::checkFile(__DIR__ . '/data/disallowImplicitArrayCreationErrors.php');
 
-		self::assertSame(8, $report->getErrorCount());
+		self::assertSame(9, $report->getErrorCount());
 
 		self::assertSniffError($report, 3, DisallowImplicitArrayCreationSniff::CODE_IMPLICIT_ARRAY_CREATION_USED);
 		self::assertSniffError($report, 7, DisallowImplicitArrayCreationSniff::CODE_IMPLICIT_ARRAY_CREATION_USED);
@@ -27,6 +27,7 @@ public function testErrors(): void
 		self::assertSniffError($report, 36, DisallowImplicitArrayCreationSniff::CODE_IMPLICIT_ARRAY_CREATION_USED);
 		self::assertSniffError($report, 41, DisallowImplicitArrayCreationSniff::CODE_IMPLICIT_ARRAY_CREATION_USED);
 		self::assertSniffError($report, 48, DisallowImplicitArrayCreationSniff::CODE_IMPLICIT_ARRAY_CREATION_USED);
+		self::assertSniffError($report, 54, DisallowImplicitArrayCreationSniff::CODE_IMPLICIT_ARRAY_CREATION_USED);
 	}
 
 }
diff --git a/tests/Sniffs/Arrays/data/disallowImplicitArrayCreationErrors.php b/tests/Sniffs/Arrays/data/disallowImplicitArrayCreationErrors.php
@@ -47,3 +47,9 @@ function undefinedVariable()
 	$b = $a ? true : false;
 	$a[] = 2;
 }
+
+function notImportedViaGlobalStatement()
+{
+	static $something, $value, $somethingElse;
+	$value[] = 'a';
+}
diff --git a/tests/Sniffs/Arrays/data/disallowImplicitArrayCreationNoErrors.php b/tests/Sniffs/Arrays/data/disallowImplicitArrayCreationNoErrors.php
@@ -90,3 +90,9 @@ function staticVariable()
 	static $value;
 	$value[] = true;
 }
+
+function importedViaGlobalStatement()
+{
+	global $something, $value, $somethingElse;
+	$value[] = 'a';
+}