UselessParenthesesSniff: Fixed false positive

slevomat · Dec 13, 2019 · 3cb0587 · 3cb0587
1 parent 742e60b
commit 3cb0587
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php b/SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php
@@ -461,6 +461,10 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes
 			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && in_array($tokens[$firstOperatorPointer]['code'], [T_DIVIDE, T_MULTIPLY], true)) {
 				return;
 			}
+
+			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_MODULUS && $tokens[$firstOperatorPointer]['code'] === T_MODULUS) {
+				return;
+			}
 		}
 
 		$lastOperatorPointer = $operatorsPointers[count($operatorsPointers) - 1];

diff --git a/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php b/tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php
@@ -133,6 +133,8 @@ function () {
 
 $a = 10 - (5 - 2);
 
+$a = 6 % (5 % 3);
+
 pow(10, -($x + 1));
 
 if (! ($i === $j - 1)) {
-Original file line number
+Diff line change
@@ Expand Up @@
     			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_DIVIDE && in_array($tokens[$firstOperatorPointer]['code'], [T_DIVIDE, T_MULTIPLY], true)) {
     				return;
     			}
+    			if ($tokens[$pointerBeforeParenthesisOpener]['code'] === T_MODULUS && $tokens[$firstOperatorPointer]['code'] === T_MODULUS) {
+    				return;
+    			}
     		}
     		$lastOperatorPointer = $operatorsPointers[count($operatorsPointers) - 1];
@@ Expand Down @@