Replaces __call with static methods #120
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I don't see any reason to implement the
search
andsuggest
methods in__call
instead of just exposing static methods ? Maybe I missed something ?The problem of overloading the
__call
method from a trait is that other traits may overload it too, and it can't simply be solved by aliasing them because they all callparent::__ call
, the only solution would be to manually merge the code of all the__call
into a single method, but that's weird.For example, I encountered this problem while using the
Searchable
trait in combination with this one :https://github.com/Laravel-Backpack/CRUD/blob/master/src/ModelTraits/SpatieTranslatable/HasTranslations.php