Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sortedrun under package #56

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Move sortedrun under package #56

merged 3 commits into from
Dec 27, 2024

Conversation

naveen246
Copy link
Collaborator

@naveen246 naveen246 commented Dec 23, 2024

Move sortedrun to compacted package
Move tablestore to store package

@naveen246 naveen246 requested a review from thrawn01 December 23, 2024 19:19
@naveen246 naveen246 mentioned this pull request Dec 23, 2024
@thrawn01
Copy link
Collaborator

I think we should move these packages under internal/ and eventually remove the slatedb/ directory.

@thrawn01
Copy link
Collaborator

What about calling it compaction instead of compacted ? I say this because I that is what the package does, as apposed to what the package's final outcome is. It's subtle, but should avoid confusion.

@naveen246
Copy link
Collaborator Author

I think we should move these packages under internal/ and eventually remove the slatedb/ directory.

will do this in future PRs

@naveen246
Copy link
Collaborator Author

What about calling it compaction instead of compacted ? I say this because I that is what the package does, as apposed to what the package's final outcome is. It's subtle, but should avoid confusion.

Changed to compaction

@thrawn01 thrawn01 merged commit 59176a2 into slatedb:main Dec 27, 2024
3 checks passed
@naveen246 naveen246 deleted the refactor branch January 2, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants