Merge pull request #6 from jonsterling/ready/5

Memoize feature detection (resolve #5)
slamdata · Sep 8, 2015 · ba8a025 · ba8a025
2 parents cfd1013 + e889aff
commit ba8a025
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/src/DOM/BrowserFeatures/Detectors.js b/src/DOM/BrowserFeatures/Detectors.js
@@ -1,7 +1,13 @@
 // module DOM.BrowserFeatures.Detectors
 
+var _inputTypeSupportMemoTable = {};
+
 exports._detectInputTypeSupport = function(type) {
   return function() {
+    if (_inputTypeSupportMemoTable.hasOwnProperty(type)) {
+      return _inputTypeSupportMemoTable[type];
+    }
+
     var el = document.createElement("input");
 
     try {
@@ -10,6 +16,9 @@ exports._detectInputTypeSupport = function(type) {
       return false;
     }
 
-    return el.type === type;
+    var result = el.type === type;
+    _inputTypeSupportMemoTable[type] = result;
+
+    return result;
   };
 };
diff --git a/test/Main.purs b/test/Main.purs
@@ -11,6 +11,13 @@ import DOM.BrowserFeatures.Detectors
 
 main :: Eff (dom :: DOM, console :: CONSOLE) Unit
 main = do
-  features <- detectBrowserFeatures
-  void $ for IT.allInputTypes \ty ->
-    log $ show ty ++ if features.inputTypeSupported ty then " supported" else " not supported"
+  queryFeatureSupport
+  log "Will query feature support again, using memoized results"
+  queryFeatureSupport
+  log "Done"
+
+  where
+    queryFeatureSupport = do
+      features <- detectBrowserFeatures
+      void $ for IT.allInputTypes \ty ->
+        log $ show ty ++ if features.inputTypeSupported ty then " supported" else " not supported"