Use NTScalarArray for 1D arrays. #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Candidate v6.1.1
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #977 +/- ##
==========================================
- Coverage 30.02% 30.01% -0.01%
==========================================
Files 65 65
Lines 6634 6636 +2
Branches 1013 1014 +1
==========================================
Hits 1992 1992
- Misses 4485 4487 +2
Partials 157 157
|
omar-moreno
changed the title
bengineerd
approved these changes
Oct 24, 2023
ruck314
approved these changes
Oct 27, 2023
|
@omar-moreno Confirmed this worked with your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the protocol epicsV4 to use the normative type
NTScalarwhen a 1D array is encountered. Currently, the typeNTNDArrayis being used but that is meant to encode a data frame from a detector or an image from a camera.Description
Make use of the normative type
NTScalarwhen encoding 1D arrays inpyrogue.protocols.epicsV4.JIRA
https://jira.slac.stanford.edu/browse/ESROGUE-640
Related
This PR addresses the following issue: slaclab/darpa-accel-llrf-phase-1p5#6