Adding C++ linter to CI #1012
Merged
Adding C++ linter to CI #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
If an else has a brace on one side, it should have it on both [readability/braces]
Line contains only semicolon. If this should be an empty statement, use {} instead. [whitespace/semicolon]
Multi-line string (...) found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string]
Missing space after , [whitespace/comma]
Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent]
public: should be indented +1 space inside class [whitespace/indent]
Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent]
At least two spaces is best between code and comments [whitespace/comments]
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting]
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line]
Empty loop bodies should use {} or continue [whitespace/empty_loop_body]
An else should appear on the same line as the preceding } [whitespace/newline]
Extra space before ( in function call [whitespace/parens]
Mismatching spaces inside () in if [whitespace/parens]
Add #include <XXX> for XXX [build/include_what_you_use]
Using C-style cast. Use static_cast<XXXX>(...) instead [readability/casting]
Never use XXXX. Use snprintf instead. [runtime/printf]
Use operator XXX instead of YYY [readability/alt_tokens]
Use int16/int64/etc, rather than the C type long [runtime/int]
Extra space for operator ++; [whitespace/operators]
'sys/syscall.h' already included at ./src/rogue/Logging.cpp:27 [build/include]
Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration. [build/storage_class]
Single-parameter constructors should be marked explicit. [runtime/explicit]
'virtual' is redundant since function is already declared as 'final' [readability/inheritance]
Namespace should be terminated with '// namespace CRCPP' [readability/namespace]
|
Completed a hardware regression test on 10GbE RUDP example with XVC running. Seems to work and no change in behavior |
bengineerd
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description