cleanup how logging is handled #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idea is that logging should be used for most output (prints for debugging and other messy output could still be fine). This is to avoid confusion when mixing logs and prints. Should try to use appropriate log level: logger.info(), logger.error(), logger.exception() In this patch: -setup moved to inside library, no longer per highlevel script -remove logs folder and by default have single log.txt file in project root -add cmdline option to specify log-file, so can still easily have one-off and script specific log-files Followup patch will update suite_scripts files to remove redundant print calls
nstelter-slac
force-pushed
the
logging_fix
branch
from
7855707 to
faa32e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit comment and doc update for more details
we want to log and also to print to terminal, without calls to both log and print. easiest way seems to use log statement and set it up to also write to the terminal.
prints can of course still be used for debugging or anything else, but to avoid confusion with mixed logs and prints it might best to use just log calls for any significant output.
can just use the BasicSuiteScripts class "logger" object with different log levels: