Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move executable to cmd directory #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

IxDay
Copy link

@IxDay IxDay commented Oct 19, 2018

Move executable to cmd directory

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

This patch also allow this repository to be imported in another project.
Only the execution part and config loading is moved to the cmd directory
allowing the use of the core features in other projects.

Related Issues

None for the moment, can open one if needed for traceability.

Test strategy

Keep tests passing as it is only a refactoring.

Maxime Vidori added 2 commits November 6, 2018 17:01
This patch also allow this repository to be imported in another project.
Only the execution part and config loading is moved to the cmd directory
allowing the use of the core features in other projects.
@awprice
Copy link

awprice commented Jun 28, 2019

@nbrownus / @rawdigits / @IxDay
I would love to see this PR merged as it will allow me to use go-audit in a project I am working on. What can we do to get this moving?

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Maxime Vidori seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nbrownus
Copy link
Collaborator

👋 @IxDay thanks for the PR, can you do the CLA for us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants