Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port to javascript #652

Closed
wants to merge 2 commits into from
Closed

Conversation

joeyguerra
Copy link

BREAKING CHANGE: Code has been ported to javascript from coffeescript.

I used https://decaffeinate-project.org

npx decaffeinate ./src
npx decaffeinate ./test

And then I modified test/stubs.js so it can be shared across the tests.

#429

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

BREAKING CHANGE: Code has been ported to javascript from coffeescript.
@salesforce-cla
Copy link

salesforce-cla bot commented Jun 4, 2023

Thanks for the contribution! Before we can merge this, we need @joeyguerra to sign the Salesforce Inc. Contributor License Agreement.

@joeyguerra
Copy link
Author

@seratch Are you available to assist in reviewing this PR? Or do you know someone who might be?

@filmaj
Copy link

filmaj commented Jun 5, 2023

Hey @joeyguerra, really appreciate you taking the time to put a pull request together, but as stated in our README, only critical security issues will be addressed and merged into this repo as this repo is no longer under active development.

For larger changes, such as this PR, I recommend keeping them to your fork.

@joeyguerra
Copy link
Author

Hi @filmaj. Cool. Thank you for responding. I'll fork it.

@joeyguerra joeyguerra closed this Jun 5, 2023
@joeyguerra joeyguerra deleted the es6js-port branch July 27, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants