This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Move trigger construction into triggers/
directory
#14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
This PR follows from this conversation and relocates trigger definition logic into the
triggers/
directory. This approach brings a few questions since this is a trigger created at runtime with dynamic inputs, while definitions in this directory are often static or created via the CLI.This is only one approach for making this change. An alternative might move the entire creation process (including the API call) into the trigger definition file. Another may use a complete definition with blank inputs in place of the dynamic
channel
value, and populate these values from the custom function. I'm sure there are other ways to dice this too!Open questions and thoughts
findUserJoinedChannelTrigger
, which is unique to theSendWelcomeMessage
workflow's event trigger in this app?triggers/
directory that is also created at runtime can be found in the deno-simple-survey repo (trigger definition, trigger creation).channel_id
values that might be better?Requirements