Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add required attributes to function and workflow definition inputs #63

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: add required attributes to function and workflow definition inputs #63

merged 1 commit into from
Apr 9, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Apr 9, 2024

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR adds required attributes to the definitions of the included workflows and functions so that everything completes as expected every time.

Fixes a possible problem of a trigger being created without channel for the sample_workflow and undefined inputs if the sample_function is distributed.

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added the bug Something isn't working label Apr 9, 2024
@zimeg zimeg self-assigned this Apr 9, 2024
hello-ashleyintech
hello-ashleyintech approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯 thank you for the fix! 🙌

@zimeg
Copy link
Member Author

zimeg commented Apr 9, 2024

@hello-ashleyintech and thank you kindly for the review 👏 👏

@zimeg zimeg merged commit 80b3d37 into main Apr 9, 2024
2 checks passed
@zimeg zimeg deleted the fix-required-attributes branch April 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hello-ashleyintech hello-ashleyintech hello-ashleyintech approved these changes

@misscoded misscoded Awaiting requested review from misscoded

Assignees

@zimeg zimeg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @hello-ashleyintech