Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import external dependencies with the import map #53

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Import external dependencies with the import map #53

merged 1 commit into from
Oct 30, 2023

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Oct 30, 2023

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR moves module imports into the import_map.json file for easier updating.

Notes

  • An update to the deno-sample-dependencies repo will follow!

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added the enhancement New feature or request label Oct 30, 2023
@zimeg zimeg self-assigned this Oct 30, 2023
@zimeg
Copy link
Member Author

zimeg commented Oct 30, 2023

@filmaj appreciate the reviews - thank you! 🕺

@zimeg zimeg merged commit a3e81dc into main Oct 30, 2023
2 checks passed
@zimeg zimeg deleted the import-maps branch October 30, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj approved these changes

@misscoded misscoded Awaiting requested review from misscoded

@hello-ashleyintech hello-ashleyintech Awaiting requested review from hello-ashleyintech

Assignees

@zimeg zimeg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @filmaj