Gracefully handle errors from the datastore.put response
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello-ashleyintech
approved these changes
Oct 30, 2023
|
@hello-ashleyintech no worries at all! The LGTM is always appreciated 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
This PR adds error handling to the
datastore.putcall, returning an error if this call is unsuccessful. Related tests are also added.Unsure if this is the ideal way to mock different responses or if this is how we'd like to handle this error case, so please feel free to suggest alternatives!
Notes
Mocked responses were updated to match https://api.slack.com/methods/apps.datastore.put#examples
Requirements