Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra select-auth step #35

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Add extra select-auth step #35

merged 2 commits into from
Aug 17, 2023

Conversation

wongjas
Copy link
Contributor

@wongjas wongjas commented Aug 8, 2023

Type of change (place an x in the [ ] that applies)

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

As of v2.3.0, after using the slack external-auth add command, you need to use the slack external-auth select-auth command if credential_source: "DEVELOPER". Adding this into the instructions since the instructions error out without this at the moment.

Requirements (place an x in each [ ] that applies)

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@wongjas wongjas requested a review from zimeg August 8, 2023 05:55
@wongjas wongjas self-assigned this Aug 8, 2023
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate this addition, thank you! 🙌

There's a formatting issue from line length that was causing the CI to fail, but running a quick deno fmt can fix this.

I also left a note that adds some detail for this command, but your call on this change!

Approving now since this change is good, but I'm also wondering if we might update this sample to use end user authentication instead? I'll check on this, not a blocker to this PR!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ethan Zimbelman <[email protected]>
@wongjas wongjas merged commit 102f1ed into main Aug 17, 2023
@wongjas wongjas deleted the jwong-update-readme branch August 17, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants