clear sky detection module #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giray98
temporarily deployed
to
test-deployment
GitHub Actions
Inactive
giray98
temporarily deployed
to
test-deployment
GitHub Actions
Inactive
bmeyers
reviewed
Aug 14, 2024
| self.dh = data_handler | ||
| self.dilation = Dilation(data_handler, **config) # Create an instance of Dilation | ||
| self.cake = self.dilation.signal_dil # Get the 'cake' from the Dilation instance | ||
| self.Q98 = data_handler.Q98 # Assuming 'Q98' is still stored in data_handler |
There was a problem hiding this comment.
I don't believe this is a standard attribute of the data handler
There was a problem hiding this comment.
If you are mentioning the fact that 98th percentile is not in data handler, yes I am aware. Otherwise I will check from Dilation object on how to use data handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new class called "clear sky detection" mimicking dilation module. Not complete yet but main functionalities are there...