Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This should just change gh actions test to be faster #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nimish
Copy link

@nimish nimish commented Apr 27, 2024

Merging new features and bug fixes

@nimish nimish force-pushed the gh-actions-1 branch 9 times, most recently from 7ceec01 to fa8f56f Compare April 27, 2024 23:22
Copy link
Collaborator

@pluflou pluflou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimish thanks for all this! I think most of these are a little outdated now with the latest main. Could you pull the new changes and update it? Alternatively we could have a code review session on Zoom and work through an update together.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/test-build.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@nimish nimish force-pushed the gh-actions-1 branch 4 times, most recently from 15972a3 to 4d1e780 Compare May 4, 2024 01:10
@nimish
Copy link
Author

nimish commented May 4, 2024

@pluflou -- rebased on the latest main. I think your updates should have applied relatively cleanly

@nimish
Copy link
Author

nimish commented May 4, 2024

@nimish thanks for all this! I think most of these are a little outdated now with the latest main. Could you pull the new changes and update it? Alternatively we could have a code review session on Zoom and work through an update together.

I think I got everything -- can hop on a call this weekend/next week

@pluflou
Copy link
Collaborator

pluflou commented May 10, 2024

Build workflows didn't capture the git tags correctly--it's taking it as version 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants