Skip to content

Commit

Permalink
Merge pull request #133 from slacgismo/solver-fix
Browse files Browse the repository at this point in the history
pass solver correctly to _cvx SD functions
  • Loading branch information
pluflou authored Mar 26, 2024
2 parents 1535066 + 970d3ec commit d2a9848
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions solardatatools/signal_decompositions.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def l2_l1d1_l2d2p365(
yearly_periodic=yearly_periodic,
return_all=return_all,
transition_locs=transition_locs,
solver=solver,
verbose=verbose,
)
elif yearly_periodic:
Expand Down Expand Up @@ -172,6 +173,7 @@ def tl1_l2d2p365(
w1=w1,
yearly_periodic=yearly_periodic,
return_all=return_all,
solver=solver,
verbose=verbose,
)
else:
Expand Down Expand Up @@ -226,7 +228,8 @@ def l1_l1d1_l2d2p365(
if solver == "MOSEK":
# MOSEK weights set in CVXPY function
res = _cvx_l1_l1d1_l2d2p365(
signal=signal, use_ixs=use_ixs, return_all=return_all, verbose=verbose
signal=signal, use_ixs=use_ixs, return_all=return_all,
solver=solver, verbose=verbose
)
else:
res = _osd_l1_l1d1_l2d2p365(
Expand Down Expand Up @@ -264,7 +267,8 @@ def l2_l1d2_constrained(
"""
if solver == "MOSEK":
# MOSEK weights set in CVXPY function
res = _cvx_l2_l1d2_constrained(signal, return_all=return_all, verbose=verbose)
res = _cvx_l2_l1d2_constrained(signal, return_all=return_all,
solver=solver, verbose=verbose)
else:
res = _osd_l2_l1d2_constrained(
signal, w0=w0, w1=w1, return_all=return_all, solver=solver, verbose=verbose
Expand Down

0 comments on commit d2a9848

Please sign in to comment.