Found a mistake with how mean_absolute_error was calculated

slacgismo · Aug 5, 2024 · 17e3489 · 17e3489
1 parent 6ee58ec
commit 17e3489
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/workers/src/pvinsight-validation-runner.py b/workers/src/pvinsight-validation-runner.py
@@ -1230,7 +1230,8 @@ def p_absolute_error(output: pd.Series, ground_truth: pd.Series):
     def p_mean_absolute_error(output: pd.Series, ground_truth: pd.Series):
         output.index = ground_truth.index
         difference = output - ground_truth
-        mean_absolute_error = np.mean(difference)
+        absolute_difference = np.abs(difference)
+        mean_absolute_error = np.mean(absolute_difference)
         return mean_absolute_error
 
     performance_metrics_map = {