Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ui #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ui #13

wants to merge 2 commits into from

Conversation

mochen1228
Copy link
Collaborator

Added UI modules, made changes to gitignore

@mochen1228 mochen1228 requested a review from gcezar December 1, 2020 20:02
@jongoncalves
Copy link
Contributor

I'm a little confused here. Are these assets code we wrote or are they being pulled in as third party dependencies?
If the latter, they should not be committed. They should be installed or referenced accordingly. Also, please update the readme.
One last question, what's the difference between devine_ui and django application in the app folder?

Copy link
Contributor

@gcezar gcezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments as Jonathan.

@mochen1228
Copy link
Collaborator Author

Hi. The app was based on a open source react dashboard template. I will cite them correctly and accordingly. I will also update the readme as soon as possible. For the Django app, I believe it is for the backend on injecting the real-time data to the database, which is separate from this React app. I'll get the issues you addressed fixed as soon as possible,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants